ADDED - Admin SEO page, robots/sitemap hardening and media/maintenance security fixes

SEO - New Settings > SEO admin page (seo_settings in app_config): indexing switch, Google/Bing verification, X handle, JSON-LD identity (Person/Organization, sameAs), per-locale keywords, readiness checklist and open links for sitemap.xml / robots.txt / manifest. - robots.txt is now dynamic: disallows admin, api, success and coming-soon paths; blocks everything while indexing is off or maintenance is on. - sitemap.xml carries hreflang alternates per URL, lists only categories with published projects, and is empty while hidden. - Metadata: robots + verification meta, og:locale in de_DE/en_US/ar_AR form, alternateLocale, twitter site/creator, project cover as OG image with article type, noindex on /success and /coming-soon. - JSON-LD: WebSite + publisher graph on all public pages, CreativeWork per project (view-mode independent). Security - Maintenance bypass now requires a correctly signed admin cookie; the middleware previously only checked the cookie existed. Token helpers moved to lib/admin-session-token.ts (shared by proxy.ts and lib/admin-auth.ts). - Media uploads: magic-byte validation against the declared type, SVG sanitization (script/handlers/foreignObject/javascript: rejected), upload folder sanitized, kind inferred from the real file. - Media route: fixed prefix-based path check that accepted sibling directories, unknown extensions return 404, nosniff header, CSP sandbox on SVG, gif content type added. - External media URLs: protocol-relative (//host) URLs rejected. Portfolio - Project and category slugs share /portfolio/[slug]; saving now rejects a slug already used on the other side instead of silently shadowing it. Tooling/docs - Lint: ignore scripts/legacy-prisma-seed.cjs, drop unused import. - New docs/SEO.md; FEATURES, ARCHITECTURE (Drizzle instead of Prisma), admin spec and CLAUDE.md updated. - Tests for all of the above (unit + integration); suite green.
2026-09-20 21:36:16 +02:00
parent 0b513551ca
commit dc21c33867
47 changed files with 1854 additions and 131 deletions
@@ -7,6 +7,7 @@ import {
  MEDIA_UPLOAD_ROOT,
  getExtensionForMimeType,
  isManagedMediaFilePath,
+  isMediaContentValid,
  removeManagedMediaFile,
  resolveMediaUploadPath,
  sanitizeBaseName,
@@ -69,6 +70,42 @@ describe("resolveMediaUploadPath", () => {
  it("throws when a traversal attempt escapes the root", () => {
    expect(() => resolveMediaUploadPath("/uploads/media/../../etc/passwd")).toThrow(/escapes/i);
  });
+
+  it("rejects a sibling directory that merely shares the root prefix", () => {
+    // `.../uploads/media-evil` starts with `.../uploads/media` as a string.
+    expect(() => resolveMediaUploadPath("/uploads/media/../media-evil/x.png")).toThrow(/escapes/i);
+  });
+
+  it("rejects the root itself, empty paths and null bytes", () => {
+    expect(() => resolveMediaUploadPath("/uploads/media/")).toThrow(/escapes/i);
+    expect(() => resolveMediaUploadPath("/uploads/media/./")).toThrow(/escapes/i);
+    expect(() => resolveMediaUploadPath("/uploads/media/a\0.png")).toThrow(/escapes/i);
+  });
+});
+
+describe("isMediaContentValid", () => {
+  it("accepts files whose magic bytes match the extension", () => {
+    expect(isMediaContentValid(".png", Buffer.from([0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a, 1, 2]))).toBe(true);
+    expect(isMediaContentValid(".jpg", Buffer.from([0xff, 0xd8, 0xff, 0xe0]))).toBe(true);
+    expect(isMediaContentValid(".gif", Buffer.from("GIF89a"))).toBe(true);
+    expect(isMediaContentValid(".pdf", Buffer.from("%PDF-1.7"))).toBe(true);
+    expect(isMediaContentValid(".webp", Buffer.from("RIFF\0\0\0\0WEBPVP8 "))).toBe(true);
+  });
+
+  it("rejects mismatched bytes (e.g. HTML disguised as an image)", () => {
+    expect(isMediaContentValid(".png", Buffer.from("<html><script>alert(1)</script>"))).toBe(false);
+    expect(isMediaContentValid(".jpg", Buffer.from("GIF89a"))).toBe(false);
+    expect(isMediaContentValid(".exe", Buffer.from("MZ"))).toBe(false);
+  });
+
+  it("accepts plain svg and rejects active content", () => {
+    expect(isMediaContentValid(".svg", Buffer.from('<svg xmlns="http://www.w3.org/2000/svg"><rect/></svg>'))).toBe(true);
+    expect(isMediaContentValid(".svg", Buffer.from('<?xml version="1.0"?>\n<svg><circle/></svg>'))).toBe(true);
+    expect(isMediaContentValid(".svg", Buffer.from("<svg><script>alert(1)</script></svg>"))).toBe(false);
+    expect(isMediaContentValid(".svg", Buffer.from('<svg onload="alert(1)"></svg>'))).toBe(false);
+    expect(isMediaContentValid(".svg", Buffer.from('<svg><a xlink:href="javascript:x"/></svg>'))).toBe(false);
+    expect(isMediaContentValid(".svg", Buffer.from("<html><svg/></html>"))).toBe(false);
+  });
 });

 describe("removeManagedMediaFile", () => {