moh
dc21c33867
SEO - New Settings > SEO admin page (seo_settings in app_config): indexing switch, Google/Bing verification, X handle, JSON-LD identity (Person/Organization, sameAs), per-locale keywords, readiness checklist and open links for sitemap.xml / robots.txt / manifest. - robots.txt is now dynamic: disallows admin, api, success and coming-soon paths; blocks everything while indexing is off or maintenance is on. - sitemap.xml carries hreflang alternates per URL, lists only categories with published projects, and is empty while hidden. - Metadata: robots + verification meta, og:locale in de_DE/en_US/ar_AR form, alternateLocale, twitter site/creator, project cover as OG image with article type, noindex on /success and /coming-soon. - JSON-LD: WebSite + publisher graph on all public pages, CreativeWork per project (view-mode independent). Security - Maintenance bypass now requires a correctly signed admin cookie; the middleware previously only checked the cookie existed. Token helpers moved to lib/admin-session-token.ts (shared by proxy.ts and lib/admin-auth.ts). - Media uploads: magic-byte validation against the declared type, SVG sanitization (script/handlers/foreignObject/javascript: rejected), upload folder sanitized, kind inferred from the real file. - Media route: fixed prefix-based path check that accepted sibling directories, unknown extensions return 404, nosniff header, CSP sandbox on SVG, gif content type added. - External media URLs: protocol-relative (//host) URLs rejected. Portfolio - Project and category slugs share /portfolio/[slug]; saving now rejects a slug already used on the other side instead of silently shadowing it. Tooling/docs - Lint: ignore scripts/legacy-prisma-seed.cjs, drop unused import. - New docs/SEO.md; FEATURES, ARCHITECTURE (Drizzle instead of Prisma), admin spec and CLAUDE.md updated. - Tests for all of the above (unit + integration); suite green.
123 lines
5.2 KiB
TypeScript
123 lines
5.2 KiB
TypeScript
import path from "path";
|
|
|
|
import { describe, expect, it } from "vitest";
|
|
|
|
import {
|
|
MAX_MEDIA_FILE_SIZE,
|
|
MEDIA_UPLOAD_ROOT,
|
|
getExtensionForMimeType,
|
|
isManagedMediaFilePath,
|
|
isMediaContentValid,
|
|
removeManagedMediaFile,
|
|
resolveMediaUploadPath,
|
|
sanitizeBaseName,
|
|
} from "@/lib/media-storage";
|
|
|
|
describe("sanitizeBaseName", () => {
|
|
it("lowercases, hyphenates, and strips symbols", () => {
|
|
expect(sanitizeBaseName("Brand Redesign 2026!.svg")).toBe("brand-redesign-2026-svg");
|
|
});
|
|
|
|
it("collapses repeated separators and trims edges", () => {
|
|
expect(sanitizeBaseName("--Hello___World--")).toBe("hello-world");
|
|
});
|
|
|
|
it("truncates to 60 characters", () => {
|
|
expect(sanitizeBaseName("a".repeat(100)).length).toBe(60);
|
|
});
|
|
});
|
|
|
|
describe("getExtensionForMimeType", () => {
|
|
it("maps known image and document mime types", () => {
|
|
expect(getExtensionForMimeType("image/gif")).toBe(".gif");
|
|
expect(getExtensionForMimeType("image/jpeg")).toBe(".jpg");
|
|
expect(getExtensionForMimeType("image/png")).toBe(".png");
|
|
expect(getExtensionForMimeType("image/webp")).toBe(".webp");
|
|
expect(getExtensionForMimeType("image/svg+xml")).toBe(".svg");
|
|
expect(getExtensionForMimeType("image/x-icon")).toBe(".ico");
|
|
expect(getExtensionForMimeType("image/vnd.microsoft.icon")).toBe(".ico");
|
|
expect(getExtensionForMimeType("application/pdf")).toBe(".pdf");
|
|
});
|
|
|
|
it("returns null for unknown mime types", () => {
|
|
expect(getExtensionForMimeType("application/zip")).toBeNull();
|
|
expect(getExtensionForMimeType("")).toBeNull();
|
|
});
|
|
});
|
|
|
|
describe("isManagedMediaFilePath", () => {
|
|
it("accepts managed upload paths only", () => {
|
|
expect(isManagedMediaFilePath("/uploads/media/covers/x.svg")).toBe(true);
|
|
expect(isManagedMediaFilePath("https://example.com/x.svg")).toBe(false);
|
|
expect(isManagedMediaFilePath("../x.svg")).toBe(false);
|
|
expect(isManagedMediaFilePath("/uploads/other/x.svg")).toBe(false);
|
|
expect(isManagedMediaFilePath(null)).toBe(false);
|
|
expect(isManagedMediaFilePath(undefined)).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe("resolveMediaUploadPath", () => {
|
|
it("resolves managed paths inside the upload root", () => {
|
|
const resolved = resolveMediaUploadPath("/uploads/media/assets/test.svg");
|
|
expect(resolved.startsWith(MEDIA_UPLOAD_ROOT)).toBe(true);
|
|
expect(resolved.endsWith(path.join("assets", "test.svg"))).toBe(true);
|
|
});
|
|
|
|
it("throws for unmanaged paths", () => {
|
|
expect(() => resolveMediaUploadPath("https://example.com/x.svg")).toThrow(/managed/i);
|
|
});
|
|
|
|
it("throws when a traversal attempt escapes the root", () => {
|
|
expect(() => resolveMediaUploadPath("/uploads/media/../../etc/passwd")).toThrow(/escapes/i);
|
|
});
|
|
|
|
it("rejects a sibling directory that merely shares the root prefix", () => {
|
|
// `.../uploads/media-evil` starts with `.../uploads/media` as a string.
|
|
expect(() => resolveMediaUploadPath("/uploads/media/../media-evil/x.png")).toThrow(/escapes/i);
|
|
});
|
|
|
|
it("rejects the root itself, empty paths and null bytes", () => {
|
|
expect(() => resolveMediaUploadPath("/uploads/media/")).toThrow(/escapes/i);
|
|
expect(() => resolveMediaUploadPath("/uploads/media/./")).toThrow(/escapes/i);
|
|
expect(() => resolveMediaUploadPath("/uploads/media/a\0.png")).toThrow(/escapes/i);
|
|
});
|
|
});
|
|
|
|
describe("isMediaContentValid", () => {
|
|
it("accepts files whose magic bytes match the extension", () => {
|
|
expect(isMediaContentValid(".png", Buffer.from([0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a, 1, 2]))).toBe(true);
|
|
expect(isMediaContentValid(".jpg", Buffer.from([0xff, 0xd8, 0xff, 0xe0]))).toBe(true);
|
|
expect(isMediaContentValid(".gif", Buffer.from("GIF89a"))).toBe(true);
|
|
expect(isMediaContentValid(".pdf", Buffer.from("%PDF-1.7"))).toBe(true);
|
|
expect(isMediaContentValid(".webp", Buffer.from("RIFF\0\0\0\0WEBPVP8 "))).toBe(true);
|
|
});
|
|
|
|
it("rejects mismatched bytes (e.g. HTML disguised as an image)", () => {
|
|
expect(isMediaContentValid(".png", Buffer.from("<html><script>alert(1)</script>"))).toBe(false);
|
|
expect(isMediaContentValid(".jpg", Buffer.from("GIF89a"))).toBe(false);
|
|
expect(isMediaContentValid(".exe", Buffer.from("MZ"))).toBe(false);
|
|
});
|
|
|
|
it("accepts plain svg and rejects active content", () => {
|
|
expect(isMediaContentValid(".svg", Buffer.from('<svg xmlns="http://www.w3.org/2000/svg"><rect/></svg>'))).toBe(true);
|
|
expect(isMediaContentValid(".svg", Buffer.from('<?xml version="1.0"?>\n<svg><circle/></svg>'))).toBe(true);
|
|
expect(isMediaContentValid(".svg", Buffer.from("<svg><script>alert(1)</script></svg>"))).toBe(false);
|
|
expect(isMediaContentValid(".svg", Buffer.from('<svg onload="alert(1)"></svg>'))).toBe(false);
|
|
expect(isMediaContentValid(".svg", Buffer.from('<svg><a xlink:href="javascript:x"/></svg>'))).toBe(false);
|
|
expect(isMediaContentValid(".svg", Buffer.from("<html><svg/></html>"))).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe("removeManagedMediaFile", () => {
|
|
it("returns false without touching disk for unmanaged paths", async () => {
|
|
await expect(removeManagedMediaFile("https://example.com/x.svg")).resolves.toBe(false);
|
|
await expect(removeManagedMediaFile(null)).resolves.toBe(false);
|
|
});
|
|
});
|
|
|
|
describe("constants", () => {
|
|
it("caps media uploads at 5 MB", () => {
|
|
expect(MAX_MEDIA_FILE_SIZE).toBe(5 * 1024 * 1024);
|
|
});
|
|
});
|