moh
dc21c33867
SEO - New Settings > SEO admin page (seo_settings in app_config): indexing switch, Google/Bing verification, X handle, JSON-LD identity (Person/Organization, sameAs), per-locale keywords, readiness checklist and open links for sitemap.xml / robots.txt / manifest. - robots.txt is now dynamic: disallows admin, api, success and coming-soon paths; blocks everything while indexing is off or maintenance is on. - sitemap.xml carries hreflang alternates per URL, lists only categories with published projects, and is empty while hidden. - Metadata: robots + verification meta, og:locale in de_DE/en_US/ar_AR form, alternateLocale, twitter site/creator, project cover as OG image with article type, noindex on /success and /coming-soon. - JSON-LD: WebSite + publisher graph on all public pages, CreativeWork per project (view-mode independent). Security - Maintenance bypass now requires a correctly signed admin cookie; the middleware previously only checked the cookie existed. Token helpers moved to lib/admin-session-token.ts (shared by proxy.ts and lib/admin-auth.ts). - Media uploads: magic-byte validation against the declared type, SVG sanitization (script/handlers/foreignObject/javascript: rejected), upload folder sanitized, kind inferred from the real file. - Media route: fixed prefix-based path check that accepted sibling directories, unknown extensions return 404, nosniff header, CSP sandbox on SVG, gif content type added. - External media URLs: protocol-relative (//host) URLs rejected. Portfolio - Project and category slugs share /portfolio/[slug]; saving now rejects a slug already used on the other side instead of silently shadowing it. Tooling/docs - Lint: ignore scripts/legacy-prisma-seed.cjs, drop unused import. - New docs/SEO.md; FEATURES, ARCHITECTURE (Drizzle instead of Prisma), admin spec and CLAUDE.md updated. - Tests for all of the above (unit + integration); suite green.
89 lines
4.0 KiB
TypeScript
89 lines
4.0 KiB
TypeScript
import { beforeEach, describe, expect, it, vi } from "vitest";
|
|
|
|
vi.mock("next/cache", async () => ({ revalidatePath: (await import("@/tests/helpers/next-mocks")).revalidatePath }));
|
|
vi.mock("next/navigation", async () => ({ redirect: (await import("@/tests/helpers/next-mocks")).redirect }));
|
|
vi.mock("next/dist/client/components/redirect-error", async () => ({
|
|
isRedirectError: (await import("@/tests/helpers/next-mocks")).isRedirectError,
|
|
}));
|
|
vi.mock("@/lib/admin-auth", async () => {
|
|
const m = await import("@/tests/helpers/next-mocks");
|
|
return { isAdminAuthenticated: m.isAdminAuthenticated, clearAdminSessionCookie: m.clearAdminSessionCookie };
|
|
});
|
|
|
|
import { eq } from "drizzle-orm";
|
|
|
|
import { createMediaAssetAction, deleteMediaAssetAction } from "@/app/_admin/media/actions";
|
|
import { db } from "@/lib/db";
|
|
import { mediaAsset } from "@/lib/db/schema";
|
|
import { removeManagedMediaFile } from "@/lib/media-storage";
|
|
import { createMediaAsset, createMediaUsage } from "@/tests/helpers/factories";
|
|
import { canManageUploads } from "@/tests/helpers/fs-capability";
|
|
import { adminAuth, captureRedirect, formDataFrom, resetNextMocks } from "@/tests/helpers/next-mocks";
|
|
|
|
beforeEach(() => {
|
|
resetNextMocks();
|
|
});
|
|
|
|
describe("createMediaAssetAction", () => {
|
|
it("errors when no file is provided", async () => {
|
|
const url = await captureRedirect(() => createMediaAssetAction(formDataFrom({ kind: "IMAGE", label: "L" })));
|
|
expect(url).toContain("error=");
|
|
expect(await db.$count(mediaAsset)).toBe(0);
|
|
});
|
|
|
|
it.skipIf(!canManageUploads)("creates an asset from an uploaded file", async () => {
|
|
const file = new File([new Uint8Array([0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a])], "pic.png", { type: "image/png" });
|
|
const url = await captureRedirect(() =>
|
|
createMediaAssetAction(formDataFrom({ kind: "IMAGE", label: "Pic", file })),
|
|
);
|
|
expect(url).toContain("success=");
|
|
const assets = await db.select().from(mediaAsset);
|
|
expect(assets.length).toBe(1);
|
|
expect(assets[0].source).toBe("UPLOAD");
|
|
await removeManagedMediaFile(assets[0].url);
|
|
});
|
|
|
|
it("rejects an upload whose bytes do not match the declared image type", async () => {
|
|
const file = new File(["<html><script>alert(1)</script></html>"], "evil.png", { type: "image/png" });
|
|
const url = await captureRedirect(() =>
|
|
createMediaAssetAction(formDataFrom({ kind: "IMAGE", label: "Evil", file })),
|
|
);
|
|
expect(url).toContain("error=");
|
|
expect((await db.select().from(mediaAsset)).length).toBe(0);
|
|
});
|
|
|
|
it("redirects unauthenticated callers to the admin root", async () => {
|
|
adminAuth.authenticated = false;
|
|
const url = await captureRedirect(() => createMediaAssetAction(formDataFrom({ kind: "IMAGE", label: "L" })));
|
|
expect(url).toBe("/");
|
|
});
|
|
});
|
|
|
|
describe("deleteMediaAssetAction", () => {
|
|
it("errors when the asset does not exist", async () => {
|
|
const url = await captureRedirect(() => deleteMediaAssetAction(formDataFrom({ assetId: "missing" })));
|
|
expect(url).toContain("error=");
|
|
});
|
|
|
|
it("refuses to delete an asset that is still in use", async () => {
|
|
const asset = await createMediaAsset();
|
|
await createMediaUsage(asset.id);
|
|
const url = await captureRedirect(() => deleteMediaAssetAction(formDataFrom({ assetId: asset.id })));
|
|
expect(url).toContain("error=");
|
|
expect((await db.query.mediaAsset.findFirst({ where: eq(mediaAsset.id, asset.id) })) ?? null).not.toBeNull();
|
|
});
|
|
|
|
it("deletes an unused external asset", async () => {
|
|
const asset = await createMediaAsset({ url: "https://cdn/external.png" });
|
|
const url = await captureRedirect(() => deleteMediaAssetAction(formDataFrom({ assetId: asset.id })));
|
|
expect(url).toContain("success=");
|
|
expect((await db.query.mediaAsset.findFirst({ where: eq(mediaAsset.id, asset.id) })) ?? null).toBeNull();
|
|
});
|
|
|
|
it("redirects unauthenticated callers to the admin root", async () => {
|
|
adminAuth.authenticated = false;
|
|
const url = await captureRedirect(() => deleteMediaAssetAction(formDataFrom({ assetId: "x" })));
|
|
expect(url).toBe("/");
|
|
});
|
|
});
|